Get the type's definition in CompInfo::from_ty#3277
Closed
zmodem wants to merge 2 commits intorust-lang:mainfrom
Closed
Get the type's definition in CompInfo::from_ty#3277zmodem wants to merge 2 commits intorust-lang:mainfrom
zmodem wants to merge 2 commits intorust-lang:mainfrom
Conversation
In llvm/llvm-project#147835, Clang's AST changed so that a TagType's decl will not necessarily refer to the type's definition, but to the exact declaration which produced the type. For example, in typedef struct S T; struct S { int x; }; the 'struct S' type would refer to the incomplete type decl in the typedef, causing CompInfo to fail to see the type's definition. This patch inserts a call to use the definition when available. It fixes the original test case in rust-lang#3275 and most of the test failures caused by the Clang change but not all.
Contributor
Author
|
r? @emilio Please take a look! |
emilio
approved these changes
Aug 27, 2025
emilio
added a commit
that referenced
this pull request
Aug 27, 2025
Contributor
|
Thanks a lot for the fix! Included with the squash in #3278 |
emilio
added a commit
that referenced
this pull request
Aug 27, 2025
Contributor
Author
|
Nice! Thanks for jumping on this :-) |
emilio
added a commit
that referenced
this pull request
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In llvm/llvm-project#147835, Clang's AST changed so that a TagType's decl will not necessarily refer to the type's definition, but to the exact declaration which produced the type.
For example, in
typedef struct S T;
struct S {
int x;
};
the 'struct S' type would refer to the incomplete type decl in the typedef, causing CompInfo to fail to see the type's definition.
This patch inserts a call to use the definition when available. It fixes the original test case in
#3275 and most of the test failures caused by the Clang change but not all.