Skip to content

Enable clippy support for format-like macros#665

Merged
KodrAus merged 1 commit intorust-lang:masterfrom
nyurik:clippy-support
Feb 21, 2025
Merged

Enable clippy support for format-like macros#665
KodrAus merged 1 commit intorust-lang:masterfrom
nyurik:clippy-support

Conversation

@nyurik
Copy link
Contributor

@nyurik nyurik commented Feb 6, 2025 •
edited
Loading

Add #[clippy::format_args] as described in Clippy book

This is a new feature in v1.85

@Thomasdezeeuw
Copy link
Collaborator

Thomasdezeeuw commented Feb 21, 2025

How does this work with older Clippy versions? Is this just ignored?

@nyurik
Copy link
Contributor Author

nyurik commented Feb 21, 2025 •
edited
Loading

  • Older Clippy would work fine on anything that uses log as a dependency.
  • Older Clippy would only fail if you try to run it on the log crate itself - because it won't recognize the lint even though it thinks it "should". This is usually OK because unlike using it as a dependency, the lib itself should only be checked by one (stable) version of Clippy as part of CI

KodrAus
KodrAus approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nyurik. This looks like it should be compatible with the log! macro syntax.

@KodrAus KodrAus merged commit d777bd6 into rust-lang:master Feb 21, 2025
14 checks passed
@nyurik nyurik deleted the clippy-support branch February 22, 2025 00:21
@nyurik nyurik mentioned this pull request Feb 23, 2025
Open
@cedricschwyter cedricschwyter mentioned this pull request Mar 26, 2025
Merged
cuviper added a commit to cuviper/rust-bindgen that referenced this pull request Jul 11, 2025
@cuviper
Fix clippy::uninlined_format_args in log macros
0c6d0c0 
These are newly in effect since rust-lang/log#665.
github-merge-queue bot pushed a commit to rust-lang/rust-bindgen that referenced this pull request Jul 11, 2025
@cuviper @emilio
Fix clippy::uninlined_format_args in log macros
e23f0a7 
These are newly in effect since rust-lang/log#665.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KodrAus KodrAus KodrAus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nyurik @Thomasdezeeuw @KodrAus