Define eventfd on NetBSD by krobelus · Pull Request #4830 · rust-lang/libc

krobelus · 2025-11-16T13:24:05Z

Like FreeBSD, NetBSD supports eventfd, see
https://man.netbsd.org/eventfd.2.
OpenBSD does not AFAICT.

(for some reason my local rustfmt wants to reformat imports)

JohnTitor · 2025-11-17T11:13:34Z

src/unix/bsd/netbsdlike/netbsd/mod.rs

+    pub fn eventfd(init: c_uint, flags: c_int) -> c_int;
+    pub fn eventfd_read(fd: c_int, value: *mut eventfd_t) -> c_int;
+    pub fn eventfd_write(fd: c_int, value: eventfd_t) -> c_int;


Any reason that these fn args names don't match with man page?

rustbot · 2025-11-17T17:41:26Z

Some changes occurred in solarish module

cc @jclulow, @pfmooney

Some changes occurred in the Android module

cc @maurer

krobelus · 2025-11-17T17:42:02Z

+ pub fn eventfd_write(fd: c_int, value: eventfd_t) -> c_int; Any reason that these fn args names don't match with man page?

I might have copied it from the FreeBSD ones. Fixed

tgross35 · 2025-11-19T11:05:59Z

Please include permalinks to the headers too, manpages don't show the values. In this case: https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/eventfd.h.

To fix the CI failure you'll need to add the relevant header to libc-test/build.rs.

Why is the arg name changed in all the other files? That should be dropped, or at least moved to a separate commit if there is a reason.

tgross35

(updating status)

rustbot · 2025-11-19T11:06:15Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

krobelus · 2025-11-19T11:19:06Z

Why is the arg name changed in all the other files? That should be dropped,

I forgot to copy the commit message to the PR description - this is to match the OS manpages (or headers where I didn't find manpages).

or at least moved to a separate commit if there is a reason.

sure

Like FreeBSD but unlike OpenBSD, NetBSD supports eventfd since version 10 (September 2021, see http://netbsd.org/changes/changes-10.0.html). I don't know enough about NetBSD to know whether all systems running 10 can be expected to have eventfd, but it's probably fine. Our GitHub actions CI only tests NetBSD 10.1. Ref: https://man.netbsd.org/eventfd.2 Ref: https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/eventfd.h

rustbot · 2025-11-23T07:55:05Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

krobelus · 2025-11-23T08:18:17Z

split commits and updated tests and commit messages.
I'm not sure if this works for 100% of all NetBSD 10 systems out there,
but this was introduced in 2021 so it might be fine.

tgross35

LGTM, thank you!

(backport <rust-lang#4830>) (cherry picked from commit 3ff2a88)

Like FreeBSD but unlike OpenBSD, NetBSD supports eventfd since version 10 (September 2021, see http://netbsd.org/changes/changes-10.0.html). I don't know enough about NetBSD to know whether all systems running 10 can be expected to have eventfd, but it's probably fine. Our GitHub actions CI only tests NetBSD 10.1. Ref: https://man.netbsd.org/eventfd.2 Ref: https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/eventfd.h (backport <rust-lang#4830>) (cherry picked from commit 3e82c57)

(backport <rust-lang#4830>) (cherry picked from commit 3ff2a88)

Like FreeBSD but unlike OpenBSD, NetBSD supports eventfd since version 10 (September 2021, see http://netbsd.org/changes/changes-10.0.html). I don't know enough about NetBSD to know whether all systems running 10 can be expected to have eventfd, but it's probably fine. Our GitHub actions CI only tests NetBSD 10.1. Ref: https://man.netbsd.org/eventfd.2 Ref: https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/eventfd.h (backport <rust-lang#4830>) (cherry picked from commit 3e82c57)

(backport <rust-lang#4830>) (cherry picked from commit 3ff2a88)

Like FreeBSD but unlike OpenBSD, NetBSD supports eventfd since version 10 (September 2021, see http://netbsd.org/changes/changes-10.0.html). I don't know enough about NetBSD to know whether all systems running 10 can be expected to have eventfd, but it's probably fine. Our GitHub actions CI only tests NetBSD 10.1. Ref: https://man.netbsd.org/eventfd.2 Ref: https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/eventfd.h (backport <rust-lang#4830>) (cherry picked from commit 3e82c57)

(backport <rust-lang#4830>) (cherry picked from commit 3ff2a88)

Like FreeBSD but unlike OpenBSD, NetBSD supports eventfd since version 10 (September 2021, see http://netbsd.org/changes/changes-10.0.html). I don't know enough about NetBSD to know whether all systems running 10 can be expected to have eventfd, but it's probably fine. Our GitHub actions CI only tests NetBSD 10.1. Ref: https://man.netbsd.org/eventfd.2 Ref: https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/eventfd.h (backport <rust-lang#4830>) (cherry picked from commit 3e82c57)

(backport <rust-lang#4830>) (cherry picked from commit 3ff2a88)

Like FreeBSD but unlike OpenBSD, NetBSD supports eventfd since version 10 (September 2021, see http://netbsd.org/changes/changes-10.0.html). I don't know enough about NetBSD to know whether all systems running 10 can be expected to have eventfd, but it's probably fine. Our GitHub actions CI only tests NetBSD 10.1. Ref: https://man.netbsd.org/eventfd.2 Ref: https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/eventfd.h (backport <rust-lang#4830>) (cherry picked from commit 3e82c57)

(backport <#4830>) (cherry picked from commit 3ff2a88)

Like FreeBSD but unlike OpenBSD, NetBSD supports eventfd since version 10 (September 2021, see http://netbsd.org/changes/changes-10.0.html). I don't know enough about NetBSD to know whether all systems running 10 can be expected to have eventfd, but it's probably fine. Our GitHub actions CI only tests NetBSD 10.1. Ref: https://man.netbsd.org/eventfd.2 Ref: https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/eventfd.h (backport <#4830>) (cherry picked from commit 3e82c57)

(backport <#4830>) (cherry picked from commit 3ff2a88)

Like FreeBSD but unlike OpenBSD, NetBSD supports eventfd since version 10 (September 2021, see http://netbsd.org/changes/changes-10.0.html). I don't know enough about NetBSD to know whether all systems running 10 can be expected to have eventfd, but it's probably fine. Our GitHub actions CI only tests NetBSD 10.1. Ref: https://man.netbsd.org/eventfd.2 Ref: https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/eventfd.h (backport <#4830>) (cherry picked from commit 3e82c57)

(backport <#4830>) (cherry picked from commit 3ff2a88)

Like FreeBSD but unlike OpenBSD, NetBSD supports eventfd since version 10 (September 2021, see http://netbsd.org/changes/changes-10.0.html). I don't know enough about NetBSD to know whether all systems running 10 can be expected to have eventfd, but it's probably fine. Our GitHub actions CI only tests NetBSD 10.1. Ref: https://man.netbsd.org/eventfd.2 Ref: https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/eventfd.h (backport <#4830>) (cherry picked from commit 3e82c57)

rustbot added O-unix S-waiting-on-review labels Nov 16, 2025

krobelus force-pushed the netbsd-eventfd branch from f0917cc to 03be810 Compare November 16, 2025 14:06

JohnTitor reviewed Nov 17, 2025

View reviewed changes

krobelus force-pushed the netbsd-eventfd branch from 03be810 to 2bf5e32 Compare November 17, 2025 17:41

rustbot added O-android O-illumos O-linux O-solarish labels Nov 17, 2025

JohnTitor force-pushed the netbsd-eventfd branch from 2bf5e32 to 916a8cf Compare November 18, 2025 12:40

This comment has been minimized.

Sign in to view

tgross35 requested changes Nov 19, 2025

View reviewed changes

rustbot added S-waiting-on-author and removed S-waiting-on-review labels Nov 19, 2025

krobelus force-pushed the netbsd-eventfd branch from 916a8cf to 7b5296c Compare November 23, 2025 07:54

krobelus added 2 commits November 23, 2025 08:54

Make eventfd argument names match OS docs/headers

c627f83

krobelus force-pushed the netbsd-eventfd branch from 7b5296c to 54559ab Compare November 23, 2025 07:55

tgross35 approved these changes Nov 30, 2025

View reviewed changes

tgross35 added this pull request to the merge queue Nov 30, 2025

Merged via the queue into rust-lang:main with commit 3e82c57 Nov 30, 2025
50 checks passed

tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Dec 2, 2025

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025

Make eventfd argument names match OS docs/headers

fbd6fa2

(backport <rust-lang#4830>) (cherry picked from commit 3ff2a88)

tgross35 mentioned this pull request Dec 2, 2025

[0.2] Backports #4856

Merged

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025

Make eventfd argument names match OS docs/headers

e4b0312

(backport <rust-lang#4830>) (cherry picked from commit 3ff2a88)

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025

Make eventfd argument names match OS docs/headers

7587ed6

(backport <rust-lang#4830>) (cherry picked from commit 3ff2a88)

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025

Make eventfd argument names match OS docs/headers

d2393c4

(backport <rust-lang#4830>) (cherry picked from commit 3ff2a88)

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 2, 2025

Make eventfd argument names match OS docs/headers

210a971

(backport <rust-lang#4830>) (cherry picked from commit 3ff2a88)

github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025

Make eventfd argument names match OS docs/headers

a784abb

(backport <#4830>) (cherry picked from commit 3ff2a88)

github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025

Make eventfd argument names match OS docs/headers

c8c3ab4

(backport <#4830>) (cherry picked from commit 3ff2a88)

github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025

Make eventfd argument names match OS docs/headers

03b7438

(backport <#4830>) (cherry picked from commit 3ff2a88)

tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Dec 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Define eventfd on NetBSD#4830

Define eventfd on NetBSD#4830
tgross35 merged 2 commits intorust-lang:mainfrom
krobelus:netbsd-eventfd

krobelus commented Nov 16, 2025 •

edited

Loading

Uh oh!

JohnTitor Nov 17, 2025

Uh oh!

rustbot commented Nov 17, 2025

Uh oh!

krobelus commented Nov 17, 2025 via email

Uh oh!

This comment has been minimized.

tgross35 commented Nov 19, 2025

Uh oh!

tgross35 left a comment

Uh oh!

rustbot commented Nov 19, 2025

Uh oh!

krobelus commented Nov 19, 2025

Uh oh!

rustbot commented Nov 23, 2025

Uh oh!

krobelus commented Nov 23, 2025

Uh oh!

tgross35 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

krobelus commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JohnTitor Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

rustbot commented Nov 17, 2025

Uh oh!

krobelus commented Nov 17, 2025 via email

Uh oh!

This comment has been minimized.

tgross35 commented Nov 19, 2025

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

rustbot commented Nov 19, 2025

Uh oh!

krobelus commented Nov 19, 2025

Uh oh!

rustbot commented Nov 23, 2025

Uh oh!

krobelus commented Nov 23, 2025

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

krobelus commented Nov 16, 2025 •

edited

Loading