Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@sthibaul this should fix crashes when using this struct (by calling uname()); because of this, I'm nominating this for a backport in libc-0.2, even if "breaking".

@rustbot label stable-nominated

For reference:

• sys/utsname.h: https://sourceware.org/git/?p=glibc.git;a=blob;f=posix/sys/utsname.h;h=c6884255e04595996dbbc337ac667d0defd035f3;hb=ab564362d0470d10947c24155ec048c4e14a009d
  • the general definition of the utsname struct
• bits/utsname.h: https://sourceware.org/git/?p=glibc.git;a=blob;f=bits/utsname.h;h=c5c57e840397d9efa6ad6a3b614569d094d26c21;hb=ab564362d0470d10947c24155ec048c4e14a009d
  • the actual bits used on Hurd, setting 1024 as fields size and not enabling domainname

agreed!

Thanks for the sources, agreed that we can backport this (thanks for the ack @sthibaul).

Could you add const _UTSNAME_LENGTH: usize = 1024; and use that to make it a bit more consistent and greppable?

Could you add const _UTSNAME_LENGTH: usize = 1024; and use that to make it a bit more consistent and greppable?

Makes sense, done so -- thanks for the suggestion!