Recognize windows-sys signatures as "C" or "system" depending on cfg#677
Merged
Conversation
Member
|
This will need to exclude x86 because Windows x86 is the only target where the "system" is not the same as "C". |
ChrisDenton
approved these changes
Nov 13, 2024
ChrisDenton
left a comment
Member
There was a problem hiding this comment.
Thanks!
CI is currently failing for unrelated reasons but the change is fairly straightforward and I've tested locally so I'm happy to merge this to unblock use of raw-dylib.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #676.
This is not an ideal solution because it relies on
--cfg=windows_raw_dylibto be passed tobacktraceif and only if the same flag is passed towindows-targets. In Cargo this would always be the case and in Buck it's easy to arrange; not sure about different build systems.I did not come up with a way to write a check that succeeds if
super::windows_sys::$nameisunsafe extern "C" fn($($argty),*) -> $retORunsafe extern "system" fn($($argty),*) -> $retand fails for all other signatures.