Document order guarantees for combinations#822
Conversation
|
CI failed because rustfmt does not accept trailing spaces. The question is if we want this guarantee to be library wide or limited to some adaptors like |
Ah yes, I hope I didn't misunderstand the conclusion from the other issue. I originally wanted a guarantee for Combination-like adapters, but I interpreted your comments as saying we don't intend to break iteration order for any adapters. I could add a blanket "unless otherwise noted" clause, if there are specific adapters we'd like to leave open to further optimizations? |
|
Sorry for the misunderstanding. I don't think we can guarantee order for all adaptors, but I am okay guaranteeing it for the combinations adaptors. |
acf190e to
cb56ed1
Compare
|
Thank you for the clarification, I've updated this PR so that the guarantee is only shown under |
|
@jswrenn What do you think of his formulation? |
jswrenn
left a comment
There was a problem hiding this comment.
Whoops, I had a draft review I thought I had posted. Thanks for the ping. It's just some minor nits.
|
@ryanavella If you could commit jswrenn' suggestions and squash into a single commit, I would gladly merge this. EDIT: Done. |
dcf1503 to
56ce9a5
Compare
|
@jswrenn My approval is not enough to get this merged. |
Fixes #819 by documenting the order guarantees for Itertools adapters.