Make the data from an ExpectFile accessible#43
Merged
quad merged 1 commit intorust-analyzer:masterfrom Apr 1, 2024
Merged
Conversation
Contributor
|
This definitely makes sense. Could you bump a version in Cargo.toml to 1.5.0 so that this automatically gets released? |
Contributor
|
Oh, and mention this in the changelog! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using
expect-testin probably a weird semi-abusive way.I'm writing tests for a network protocol. My tests run in one of three modes:
expect-testflow withUPDATE_EXPECT=1; records both the inputs and outputs to the live systemexpect-testflow withUPDATE_EXPECT=0; asserts on both the inputs and outputs and fails if they've changed.datato supply the inputs and asserts only on the outputs from the implementation.It would be helpful if
ExpectFilelet me see into underlyingdataas easily asExpectdoes.