Fix non-bundled tests against macOS system SQLite#1153
Merged
thomcc merged 1 commit intorusqlite:masterfrom Apr 3, 2022
Merged
Fix non-bundled tests against macOS system SQLite#1153thomcc merged 1 commit intorusqlite:masterfrom
thomcc merged 1 commit intorusqlite:masterfrom
Conversation
Member
Author
|
I'm just going to land this after CI is green since it's trivial and is bothering me right now. |
Codecov Report
@@ Coverage Diff @@
## master #1153 +/- ##
=======================================
Coverage 78.21% 78.22%
=======================================
Files 47 47
Lines 5927 5929 +2
=======================================
+ Hits 4636 4638 +2
Misses 1291 1291
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS we fail some tests when they're run against system SQLite. These may be bugs in the macOS system SQLite (since
PRAGMA compile_optionssays thatBUG_COMPATIBLE_20160819is enabled, which seems a little ominous), but the fixes for these are easy enough.I only bothered checking that the mode behaves as expected for bundled in
test_pragma_query_rowand not inpragma_update_and_check, since the latter seems to be mostly about testing that compilation doesn't fail.