Introduce SqlInputError with offset#1137
Merged
gwenn merged 4 commits intorusqlite:masterfrom Apr 24, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
==========================================
+ Coverage 78.82% 78.86% +0.04%
==========================================
Files 48 48
Lines 6034 6051 +17
==========================================
+ Hits 4756 4772 +16
- Misses 1278 1279 +1
Continue to review full report at Codecov.
|
# Conflicts: # src/statement.rs
thomcc
approved these changes
Apr 24, 2022
Member
thomcc
left a comment
There was a problem hiding this comment.
Looks fine to me. Anything else you want to do with it still?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #1130
sqlite3_declare_vtab?SqlInputError.sql(notBatch.sql)SqlInputError.sql(notexecute_batchsql parameter)modern_sqlitefeature, I know...