Force use of buildtime_bindgen under winsqlite3 for now#1135
Merged
thomcc merged 1 commit intorusqlite:masterfrom Mar 12, 2022
Merged
Force use of buildtime_bindgen under winsqlite3 for now#1135thomcc merged 1 commit intorusqlite:masterfrom
thomcc merged 1 commit intorusqlite:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1135 +/- ##
=======================================
Coverage 78.43% 78.43%
=======================================
Files 47 47
Lines 5842 5842
=======================================
Hits 4582 4582
Misses 1260 1260 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like winsqlite3's declarations are stdcall not cdecl (
extern "system"vsextern "C"). Those are different ABIs, and it won't generally work (It will work on x86_64, but not on 32-bit x86, for example). I have a better fix incoming (maybe later this weekend -- an overhaul to libsqlite3-sys), but for now this will do.Sadly, windows is not a platform where
buildtime_bindgenis actually easy to use, so this may annoy people who use winsqlite3. It's only a build-time requirement, and I don't think there are many of users of this feature.