Add support for macos-14 GitHub runners#567
Merged
Merged
Conversation
|
Thank you for this proposal. It looks fine to me but probably |
2 tasks
Collaborator
Author
That is actually correct. It is the platform of the ruby ci used builds the binary release. |
LaStrada
reviewed
Jan 31, 2024
Collaborator
Author
|
We can probably remove the usage of self-hosted |
eregon
approved these changes
Jan 31, 2024
eregon
left a comment
Member
There was a problem hiding this comment.
Thank you, this looks great.
I'll let the CI run and then merge.
| exclude: | ||
| # https://github.com/ruby/setup-ruby/issues/496 | ||
| - { os: ubuntu-22.04, ruby: '2.2' } | ||
| # Too old, fails to compile on macos-14 (arm64) |
Member
There was a problem hiding this comment.
fails to compile? Do you have an example error?
Since we're not compiling these Rubies on macos-14 do you mean C extensions fail to compile?
Member
There was a problem hiding this comment.
Ah it's just the same as # Too old, fails to compile on macos-arm-oss below, I'll tweak the comment post-merge
Member
It's not self-hosted but macos arm runners provided by GitHub for the Ruby org. |
yolanv
referenced
this pull request
in Ordina-Group/JWorks-blog
Feb 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ruby/setup-ruby](https://togithub.com/ruby/setup-ruby) | action | minor | `v1.167.0` -> `v1.171.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ruby/setup-ruby (ruby/setup-ruby)</summary> ### [`v1.171.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.171.0): Add support for macos-14 GitHub runners [Compare Source](https://togithub.com/ruby/setup-ruby/compare/v1.170.0...v1.171.0) #### What's Changed - Update url to supported by [@​LaStrada](https://togithub.com/LaStrada) in [https://github.com/ruby/setup-ruby/pull/569](https://togithub.com/ruby/setup-ruby/pull/569) - Add support for macos-14 GitHub runners by [@​ntkme](https://togithub.com/ntkme) in [https://github.com/ruby/setup-ruby/pull/567](https://togithub.com/ruby/setup-ruby/pull/567) #### New Contributors - [@​LaStrada](https://togithub.com/LaStrada) made their first contribution in [https://github.com/ruby/setup-ruby/pull/569](https://togithub.com/ruby/setup-ruby/pull/569) - [@​ntkme](https://togithub.com/ntkme) made their first contribution in [https://github.com/ruby/setup-ruby/pull/567](https://togithub.com/ruby/setup-ruby/pull/567) **Full Changelog**: ruby/setup-ruby@v1.170.0...v1.171.0 ### [`v1.170.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.170.0): Add CRuby 3.2.3 on Windows [Compare Source](https://togithub.com/ruby/setup-ruby/compare/v1.169.0...v1.170.0) #### What's Changed - Update CRuby releases on Windows by [@​ruby-builder-bot](https://togithub.com/ruby-builder-bot) in [https://github.com/ruby/setup-ruby/pull/566](https://togithub.com/ruby/setup-ruby/pull/566) **Full Changelog**: ruby/setup-ruby@v1.169.0...v1.170.0 ### [`v1.169.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.169.0): Add windows-toolchain input [Compare Source](https://togithub.com/ruby/setup-ruby/compare/v1.168.0...v1.169.0) #### What's Changed - Add windows-toolchain input by [@​MSP-Greg](https://togithub.com/MSP-Greg) in [https://github.com/ruby/setup-ruby/pull/563](https://togithub.com/ruby/setup-ruby/pull/563) **Full Changelog**: ruby/setup-ruby@v1.168.0...v1.169.0 ### [`v1.168.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.168.0): Add ruby-3.2.3 [Compare Source](https://togithub.com/ruby/setup-ruby/compare/v1.167.0...v1.168.0) #### What's Changed - Add ruby-3.2.3 by [@​ruby-builder-bot](https://togithub.com/ruby-builder-bot) in [https://github.com/ruby/setup-ruby/pull/565](https://togithub.com/ruby/setup-ruby/pull/565) **Full Changelog**: ruby/setup-ruby@v1.167.0...v1.168.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Ordina-Group/ordina-jworks.github.io). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoic291cmNlIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
robbkidd
added a commit
to robbkidd/opentelemetry-ruby
that referenced
this pull request
May 8, 2024
To fix an error[1] on macos runners resolved in v1.171.0[2]:
The current runner (macos-14-arm64) was detected as self-hosted
because the platform does not match a GitHub-hosted runner image
(or that imageis deprecated and no longer supported).
[1] ruby/setup-ruby#568
[2] ruby/setup-ruby#567
robbkidd
added a commit
to robbkidd/opentelemetry-ruby
that referenced
this pull request
May 8, 2024
To fix an error[1] on macos runners resolved in v1.171.0[2]:
The current runner (macos-14-arm64) was detected as self-hosted
because the platform does not match a GitHub-hosted runner image
(or that imageis deprecated and no longer supported).
[1] ruby/setup-ruby#568
[2] ruby/setup-ruby#567
robertlaurin
pushed a commit
to open-telemetry/opentelemetry-ruby
that referenced
this pull request
May 8, 2024
* chore: bump ruby/setup-ruby from 1.165.1 to 1.176.0
To fix an error[1] on macos runners resolved in v1.171.0[2]:
The current runner (macos-14-arm64) was detected as self-hosted
because the platform does not match a GitHub-hosted runner image
(or that imageis deprecated and no longer supported).
[1] ruby/setup-ruby#568
[2] ruby/setup-ruby#567
* resolve missing constant error in Ruby 3.3.1
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for new macos-14 GitHub hosted runners.
Here are all current hosted runners with macos 13 or 14:
References: