Update yarn.lock, remove Windows mswin ssl cert related code#482
Merged
eregon merged 1 commit intoruby:masterfrom Mar 16, 2023
Merged
Update yarn.lock, remove Windows mswin ssl cert related code#482eregon merged 1 commit intoruby:masterfrom
eregon merged 1 commit intoruby:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSYS2 recently changed the folder that the ssl cert file is located in. 'Git for Windows' is built with MSYS2. The most recent version has the files in
etc/ssl, older versions have them inssl. Code now looks in both locations. This file is needed for Windows Rubies 2.3 and earlier, as they don't include a cert file, and the code uses the cert file included with 'Git for Windows'...The ruby-loco mswin build now has a bundled cert file. Removed the code for that.
Updated
yarn.lock.Note that the Actions images that are currently rolling out will not work without this PR. Sorry, I forgot about the 'Git for Windows' change due to the MSYS2 change...