Optimize IOSource#read_until method#210
Merged
kou merged 3 commits intoruby:masterfrom Oct 9, 2024
Merged
Conversation
kou
reviewed
Oct 7, 2024
| pattern = Private::PRE_DEFINED_TERM_PATTERNS[term] | ||
| if pattern.nil? | ||
| pattern = /#{Regexp.escape(term)}/ | ||
| term = encode(term) |
Member
There was a problem hiding this comment.
Does this work when encoding is UTF-16 or UTF-32?
Contributor
Author
There was a problem hiding this comment.
Sorry.
I have confirmed that there is a problem with UTF-16 and will change it to draft.
## Why?
The result of `encode(term)` can be cached.
## Benchmark
```
RUBYLIB= BUNDLER_ORIG_RUBYLIB= /Users/naitoh/.rbenv/versions/3.3.4/bin/ruby -v -S benchmark-driver /Users/naitoh/ghq/github.com/naitoh/rexml/benchmark/parse.yaml
ruby 3.3.4 (2024-07-09 revision be1089c8ec) [arm64-darwin22]
Calculating -------------------------------------
before after before(YJIT) after(YJIT)
dom 17.546 18.512 32.282 32.306 i/s - 100.000 times in 5.699323s 5.402026s 3.097658s 3.095448s
sax 25.435 28.294 47.526 50.074 i/s - 100.000 times in 3.931613s 3.534310s 2.104122s 1.997057s
pull 29.471 31.870 54.400 57.554 i/s - 100.000 times in 3.393211s 3.137793s 1.838222s 1.737494s
stream 29.169 31.153 51.613 52.898 i/s - 100.000 times in 3.428318s 3.209941s 1.937508s 1.890424s
Comparison:
dom
after(YJIT): 32.3 i/s
before(YJIT): 32.3 i/s - 1.00x slower
after: 18.5 i/s - 1.75x slower
before: 17.5 i/s - 1.84x slower
sax
after(YJIT): 50.1 i/s
before(YJIT): 47.5 i/s - 1.05x slower
after: 28.3 i/s - 1.77x slower
before: 25.4 i/s - 1.97x slower
pull
after(YJIT): 57.6 i/s
before(YJIT): 54.4 i/s - 1.06x slower
after: 31.9 i/s - 1.81x slower
before: 29.5 i/s - 1.95x slower
stream
after(YJIT): 52.9 i/s
before(YJIT): 51.6 i/s - 1.02x slower
after: 31.2 i/s - 1.70x slower
before: 29.2 i/s - 1.81x slower
```
- YJIT=ON : 1.00x - 1.06x faster
- YJIT=OFF : 1.05x - 1.11x faster
855c51d to
aa3d954
Compare
Contributor
Author
|
kou
reviewed
Oct 9, 2024
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The result of
encode(term)can be cached.Benchmark