Skip to content

Conversation

@Earlopain
Copy link
Contributor

They produce an assign node, but the value is part of the parent for node.

I noticed there are some flaky tests in that file being skipped. I enabled them locally, and they pass with this change.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…oops

They produce an assign node, but the value is part of the parent for node
@koic koic merged commit a3deb85 into rubocop:master Aug 27, 2024
@koic
Copy link
Member

koic commented Aug 27, 2024

Thanks!

@Earlopain Earlopain deleted the multiple-assertions-error branch August 27, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants