[Fix #14737] Fix crash in Layout/RedundantLineBreak when Layout/LineLength is disabled#14742
Merged
koic merged 1 commit intorubocop:masterfrom Dec 23, 2025
Conversation
koic
reviewed
Dec 23, 2025
|
|
||
| context 'when `Layout/LineLength` is disabled' do | ||
| let(:line_length_config) { { 'Enabled' => false } } | ||
| let(:inspect_blocks) { [false, true].sample } |
Member
There was a problem hiding this comment.
Please don't introduce randomness into test code. Can you update lets as shown below?
diff --git a/spec/rubocop/cop/layout/redundant_line_break_spec.rb b/spec/rubocop/cop/layout/redundant_line_break_spec.rb
index d00d130df..49ed6ebce 100644
--- a/spec/rubocop/cop/layout/redundant_line_break_spec.rb
+++ b/spec/rubocop/cop/layout/redundant_line_break_spec.rb
@@ -2,14 +2,17 @@
RSpec.describe RuboCop::Cop::Layout::RedundantLineBreak, :config do
let(:config) do
- RuboCop::Config.new('Layout/LineLength' => line_length_config,
+ RuboCop::Config.new('Layout/LineLength' => {
+ 'Enabled' => line_length_enabled, 'Max' => max_line_length
+ },
'Layout/RedundantLineBreak' => { 'InspectBlocks' => inspect_blocks },
'Layout/SingleLineBlockChain' => {
'Enabled' => single_line_block_chain_enabled
})
end
- let(:line_length_config) { { 'Max' => max_line_length } }
+ let(:line_length_enabled) { true }
let(:max_line_length) { 31 }
+ let(:inspect_blocks) { false }
let(:single_line_block_chain_enabled) { true }
shared_examples 'common behavior' do
@@ -777,8 +780,7 @@ RSpec.describe RuboCop::Cop::Layout::RedundantLineBreak, :config do
end
context 'when `Layout/LineLength` is disabled' do
- let(:line_length_config) { { 'Enabled' => false } }
- let(:inspect_blocks) { [false, true].sample }
+ let(:line_length_enabled) { false }
it 'registers an offense for a method call on multiple lines' do
expect_offense(<<~RUBY)…yout/LineLength` is disabled
e4bb4ed to
1873836
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14737
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.