fix: be compatible with esm output#11
Merged
chenjiahan merged 1 commit intorstackjs:mainfrom Nov 3, 2024
Merged
Conversation
chenjiahan
reviewed
Nov 3, 2024
src/prebundle.ts
Outdated
| Object.assign( | ||
| pickedPackageJson, | ||
| // will be `{"type":"module"}` if the output is of esm format | ||
| JSON.parse(assets['package.json'].source), |
Member
There was a problem hiding this comment.
All properties in source will override pickedPackageJson, such as types, is this expected?
I prefer to only override the type property
Contributor
Author
There was a problem hiding this comment.
DONE.
ncc does not intend to produce packages or types at this time. It will only create a package.json with the type field if necessary, along with fields such as exports and imports in the foreseeable future
chenjiahan
approved these changes
Nov 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Esm output is possible even though the entry file is resolved by
require.resolve. It typically happens on esm only packages, e.g., https://www.npmjs.com/package/@sindresorhus/slugifyncc creates a
package.jsonwith{ "type": "module" }. We could just merge it into thepackage.jsongenerated by prebundle.