Skip to content

fix: only respect built-in tools from CLI argv#75

Merged
chenjiahan merged 1 commit intorstackjs:mainfrom
fi3ework:builtin
Nov 10, 2025
Merged

fix: only respect built-in tools from CLI argv#75
chenjiahan merged 1 commit intorstackjs:mainfrom
fi3ework:builtin

Conversation

@fi3ework
Copy link
Copy Markdown
Member

to let pnpm create rslib --template react-js --dir my-lib2 --tools vitest --tools eslint works, that mix create-rslib's tools and create-rstack's tools together from CLI.

since create-rstack already included some built in tools (biome, prettier, eslint), so in create-rstack side, only to respect and handle the built-in tools, and the downstream consumer (such as create-rslib) will handle the rest tools.

Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit fef84bc into rstackjs:main Nov 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants