Merged
Conversation
Was not returning it to the pool if the event was nil
There was a problem hiding this comment.
Pull request overview
This PR fixes memory leaks in dictionary handling by ensuring that dictionary Event objects are always returned to the event pool after use, even when the parent Event is nil (e.g., when logging is disabled).
Changes:
- Fixed
Event.Dict()to always return dict to pool, even when Event is nil - Fixed
Array.Dict()to return dict to pool after use - Updated documentation to clarify that
Array.Dict()also clears and returns dict to pool
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| event.go | Refactored Event.Dict() to unconditionally call putEvent(dict), fixing memory leak when Event is nil |
| array.go | Added missing putEvent(dict) call in Array.Dict() to return dict to pool |
| README.md | Updated concurrency safety documentation to include Array.Dict() in the list of methods that return dict to pool |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure
dictis returned toEventpool inArray.Dict()Ensure
dictis returned toEventpool inEvent.Dict(). Previously it was not returning it to the pool if theEventwasnilUpdate Concurrency safety documentation to note that
Array.Dict()also resets thedictand returns toEventpool.Fixes #681