Value::from and full code lines coverage#498
Merged
Merged
Conversation
d44ba0f to
122abf4
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
===========================================
+ Coverage 99.40% 100.00% +0.59%
===========================================
Files 78 78
Lines 10592 11053 +461
===========================================
+ Hits 10529 11053 +524
+ Misses 63 0 -63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
87d1e5a to
041c6ec
Compare
Member
Author
|
?r @torkleyy It is possible - 100% code lines coverage 🎆 Do the |
eae54bd to
d44413e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more tests to bring
ronto 100% code lines coverage.The PR also implements convenient
Fromimpls forValue, e.g.Value::from(bool)andValue::from("my-str").CHANGELOG.md