The latest updates on your projects. Learn more about Vercel for Git ↗︎

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (13b4669) to head (32fda4e).
Report is 1 commits behind head on master.

@@            Coverage Diff             @@
##           master    #5966      +/-   ##
==========================================
+ Coverage   98.77%   98.78%   +0.01%     
==========================================
  Files         270      270              
  Lines        8734     8733       -1     
  Branches     1509     1509              
==========================================
  Hits         8627     8627              
  Misses         73       73              
+ Partials       34       33       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

In this scenario, the watch will be triggered repeatedly until the test case times out. I am not sure how to write this test case.

In this scenario, the watch will be triggered repeatedly until the test case times out. I am not sure how to write this test case.

But isn't this exactly the reason why we forbid watching inputs? To avoid infinite loops?

Yes. But in #5956 some users mentioned that our previous changes caused problems in some of their scenes. So should we add a parameter to allow the previous code logic to be maintained?

I changed the test so that while the input is in the output directory, the generated output is not also the input. I think that is indeed a valid scenario and I would merge it thus.

@lukastaegert Thank you for your review. 👍

This PR has been released as part of rollup@4.42.0. You can test it via npm install rollup.