Avoid recursively calling a plugin's resolveId hook with same id and importer#5945
Avoid recursively calling a plugin's resolveId hook with same id and importer#5945lukastaegert merged 9 commits intorollup:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5945 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 270 270
Lines 8727 8731 +4
Branches 1505 1507 +2
=======================================
+ Hits 8620 8624 +4
Misses 73 73
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks a lot! Two comments from my side, but in general I agree this is the correct solution and I do not see how we could easily achieve the same effect extending the existing logic.
|
Sorry for the long wait. I kept pondering if another approach would be less surprising where we skip plugin hooks for extended criteria, but I still keep coming back that your solution is probably the best compromise, so I will merge it now. |
|
This PR has been released as part of rollup@4.41.1. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
skipSelf: truedoes not skip the plugin if it has been called before with the same id and importer #5768Description
#5768 describes why we need to do this.
If chaining plugin hooks' call occurs,
skipwill record called plugins, thus we can break the infinity loop by find matching skippedCall inskip