Skip to content

fix: resolveId id filter is optional#5896

Merged
lukastaegert merged 1 commit intorollup:masterfrom
sapphi-red:fix/resolveid-filter-id-optional
Apr 1, 2025
Merged

fix: resolveId id filter is optional#5896
lukastaegert merged 1 commit intorollup:masterfrom
sapphi-red:fix/resolveid-filter-id-optional

Conversation

@sapphi-red
Copy link
Copy Markdown
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This should be optional for consistency with other hook filters.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 2:48am

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (22b64bc) to head (035f4a0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5896   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         270      270           
  Lines        8663     8663           
  Branches     1485     1485           
=======================================
  Hits         8539     8539           
  Misses         92       92           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukastaegert lukastaegert added this pull request to the merge queue Apr 1, 2025
Merged via the queue into rollup:master with commit d970e29 Apr 1, 2025
41 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2025

This PR has been released as part of rollup@4.39.0. You can test it via npm install rollup.

@sapphi-red sapphi-red deleted the fix/resolveid-filter-id-optional branch April 2, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants