Skip to content

return null#5820

Merged
lukastaegert merged 1 commit intorollup:masterfrom
kingma-sbw:patch-1
Feb 1, 2025
Merged

return null#5820
lukastaegert merged 1 commit intorollup:masterfrom
kingma-sbw:patch-1

Conversation

@kingma-sbw
Copy link
Copy Markdown
Contributor

Required to add default chunking

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Required to add default chunking
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 11:41pm

Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While technically not needed in non-TypeScript contexts, it definitely does not hurt.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (acd142c) to head (6d7e6d4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5820   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         260      260           
  Lines        8119     8119           
  Branches     1371     1371           
=======================================
  Hits         8021     8021           
  Misses         72       72           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert added this pull request to the merge queue Feb 1, 2025
Merged via the queue into rollup:master with commit 74a251f Feb 1, 2025
39 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2025

This PR has been released as part of rollup@4.33.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants