Skip to content

Return UnknownValue if getLiteralValueAtPath is called recursively within logical expressions#5819

Merged
lukastaegert merged 2 commits intomasterfrom
fix/5815
Feb 1, 2025
Merged

Return UnknownValue if getLiteralValueAtPath is called recursively within logical expressions#5819
lukastaegert merged 2 commits intomasterfrom
fix/5815

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5815

Description

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 8:25am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5815

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-4g6mlnor1-rollup-js.vercel.app/repl/?pr=5819

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2025

Performance report

  • BUILD: 7356ms, 737 MB
    • initialize: 0ms, 27.3 MB
    • generate module graph: 2748ms, 551 MB
      • generate ast: 1265ms, 544 MB
    • sort and bind modules: 393ms, 592 MB
    • mark included statements: 4208ms, 737 MB
      • treeshaking pass 1: 1378ms, 696 MB
      • treeshaking pass 2: 666ms, 722 MB
      • treeshaking pass 3: 277ms, 723 MB
      • treeshaking pass 4: 259ms, 727 MB
      • treeshaking pass 5: 299ms, 730 MB
      • treeshaking pass 6: 249ms, 731 MB
      • treeshaking pass 7: 233ms, 730 MB
      • treeshaking pass 8: 225ms, 737 MB
      • treeshaking pass 9: 208ms, 731 MB
      • treeshaking pass 10: 210ms, 733 MB
      • treeshaking pass 11: 207ms, 737 MB
  • GENERATE: 712ms, 974 MB
    • initialize render: 0ms, 869 MB
    • generate chunks: 74ms, 880 MB
      • optimize chunks: 0ms, 872 MB
    • render chunks: 624ms, 947 MB
    • transform chunks: 16ms, 973 MB
    • generate bundle: 0ms, 974 MB

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (f412abd) to head (85fd670).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5819   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         260      260           
  Lines        8119     8120    +1     
  Branches     1371     1372    +1     
=======================================
+ Hits         8021     8022    +1     
  Misses         72       72           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert added this pull request to the merge queue Feb 1, 2025
Merged via the queue into master with commit caeffb3 Feb 1, 2025
40 checks passed
@lukastaegert lukastaegert deleted the fix/5815 branch February 1, 2025 06:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2025

This PR has been released as part of rollup@4.33.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript enum: TypeError: Cannot set properties of undefined

2 participants