Reduce max hash size to 21#5723
Conversation
In certain cases, the maximum length was actually 21, resulting in unexpected file names and off-by-one-sourcemaps.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-5720_max_hash_sizeNotice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5723 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 258 258
Lines 8070 8070
Branches 1360 1360
=======================================
Hits 7990 7990
Misses 53 53
Partials 27 27 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.27.0. You can test it via |
In certain cases, the maximum length was actually 21, resulting in unexpected file names and off-by-one-sourcemaps.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
[hash:22]may not meet expectations #5720Description
This reduces the maximum allowed hash size from 22 to 21 as for base64, sometimes the hash size would be just 21, resulting in unexpected files names and off-by-one source maps.