Add support for FreeBSD (x64 and arm64) by tagattie · Pull Request #5698 · rollup/rollup

tagattie · 2024-10-21T11:40:52Z

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

List any relevant issue numbers:

resolves Support for FreeBSD #5491

Description

This PR contains a set of changes necessary for building and publishing native binary for FreeBSD (x64 and arm64). Changes include:

add build-freebsd job to GitHub Actions workflow
- it is difficult to add a FreeBSD-related target to existing build job, so add a dedicated job
add npm directories for freebsd-x64 and freebsd-arm64 along with changes to native.js and package.json
make small changes for rust codes
- freebsd-x64 requires local-dynamic-tls feature of mimalloc-rust crate

With those changes, npm run test:only finishes with the following output:

  5123 passing (2m)
  2 pending
  1 failing
  1) rollup
       cli
         watch
           watch-config-error: keeps watching the config file in case the config is changed to an invalid state:
     Error: Test aborted due to timeout.
      at /home/runner/work/rollup/rollup/test/cli/index.js:78:21
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

One failuer is apparently due to underlying chokidar module. A similar change to chokidar solves the error and makes all tests pass.

I would much appreciate it if this PR is considered for inclusion for future releases.

https://github.com/cross-platform-actions/action

- Add FreeBSD entries in native.js and package.json - Add directories for npm module - Patch Cargo.toml and lib.rs to enable local-dynamic-tls for FreeBSD

It seems 4 is too many.

It appears the same trick as for Linux is necessary for FreeBSD.

It takes a long time, not convenient for test.

npm run ci:test:only exits with an error: [!] RollupError: Could not resolve "../../wasm/bindings_wasm" from "browser/src/initWasm.ts"

Test on x86-64 finished almost successfully (with one error).

vercel · 2024-10-21T11:40:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 27, 2024 6:08am

lukastaegert

Looks good to me. I would merge this and create a patch release so you can check if the published version actually works as intended. And thanks so much for the work you put into this!

codecov · 2024-10-27T06:15:15Z

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.01%. Comparing base (9048a4f) to head (afe1568).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/watch/fileWatcher.ts	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5698      +/-   ##
==========================================
- Coverage   99.03%   99.01%   -0.02%     
==========================================
  Files         257      257              
  Lines        8044     8046       +2     
  Branches     1357     1358       +1     
==========================================
+ Hits         7966     7967       +1     
  Misses         52       52              
- Partials       26       27       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-10-27T06:43:53Z

This PR has been released as part of rollup@4.24.1. You can test it via npm install rollup.

lukastaegert · 2024-10-27T15:26:26Z

I overlooked that the ARM build really is abysmally slow. Not sure I would want to keep it this way, for instance when publishing, everything is waiting for this one job for 15-20 minutes (still counting). Maybe it can be made faster by running on an actual ARM platform? But I did not look into details. After all, the x86 build is quite fast.

tagattie · 2024-10-28T11:10:57Z

Yes, FreeBSD arm64 build takes a long time (over 30-40 minutes) ☹️ It's because the action (cross-platform-actions/action) uses QEMU for emulating arm64 on x86-64 platform. If it is not acceptable for the project, I would be OK to make another PR to disable arm64 build for now.

The last part of the blog post says GitHub will provide arm64 runners for open source projects by the end of the year. So I hope we can build for arm64 much faster eventually.

lukastaegert · 2024-10-28T11:45:30Z

But is it really necessary to use an arm64 platform to build for an arm64 platform? To my understanding, Rust is capable of cross-building to some degree?

tagattie · 2024-10-28T14:46:51Z

Yes, rust is indeed capable of cross-building for some target platforms. But FreeBSD arm64 platform is not (yet) supported as the target. An output from rustup target list | grep freebsd on FreeBSD x86-64 is as follows:

$ rustup target list | grep freebsd
i686-unknown-freebsd
x86_64-unknown-freebsd (installed)

So we need a native platform for building an artifact for FreeBSD arm64 at the moment...

lukastaegert · 2024-10-28T16:49:21Z

Ok, thanks for the info. So for the time being, maybe we stick with the current setup and see how annoying it is. And then let's hope that the Arm64 will really become available for Open Source eventually.

tagattie added 26 commits October 19, 2024 14:37

Add initial support for FreeBSD build

1d2a8ad

Follow the example at:

ca4ed30

https://github.com/cross-platform-actions/action

Install node modules before executing NAPI build

8a061d1

Use x86_64 to specify architecture name for amd64

e0b852b

Use rust_architecture to specify rust target architecture

fb83c78

Use settings instead of os

5da3fed

Use target to specify rust compilation target name

9f5c858

Add step for uploading built artifact

ba9ed12

Configure cpu_count and memory

e88fee5

Add support for FreeBSD

07a1e99

- Add FreeBSD entries in native.js and package.json - Add directories for npm module - Patch Cargo.toml and lib.rs to enable local-dynamic-tls for FreeBSD

Set name for build-freebsd job

1e2c7f2

Don't cancel when any matrix job fails

048f805

Move runs-on to after name

63f7f62

Set timeout for build to 60 minutes

47f2eb6

Delete CPU count

6d6c787

It seems 4 is too many.

Add test job

16b9ec4

Add FreeBSD to isLinux

3643bf7

It appears the same trick as for Linux is necessary for FreeBSD.

Temporarily disable arm64 jobs

cd64305

It takes a long time, not convenient for test.

Copy local native.js and native binary to installed rollup directory

dcc9d2a

Install git package

238a926

Use combination of build:cjs and test:only

eef9b01

npm run ci:test:only exits with an error: [!] RollupError: Could not resolve "../../wasm/bindings_wasm" from "browser/src/initWasm.ts"

Re-enable build and test for arm64

1313f0b

Test on x86-64 finished almost successfully (with one error).

Fix conditions when local-dynamic-feature is necessary

115387e

Extend timeout limit for test to 60 minutes

03bbbb2

Introduce variable to check if running on FreeBSD

aabde3d

Add build-freebsd job and remove YAML file for testing

a9ce362

vercel bot deployed to Preview October 21, 2024 11:42 View deployment

lukastaegert approved these changes Oct 27, 2024

View reviewed changes

lukastaegert enabled auto-merge October 27, 2024 06:06

Merge branch 'master' into freebsd-support

afe1568

vercel bot deployed to Preview October 27, 2024 06:08 View deployment

lukastaegert disabled auto-merge October 27, 2024 06:31

lukastaegert merged commit b9ff676 into rollup:master Oct 27, 2024

github-actions bot mentioned this pull request Oct 27, 2024

Support for FreeBSD #5491

Closed

This was referenced Oct 27, 2024

Fix "Couldn't find package" error when installing rollup using yarn #5705

Merged

@rollup/rollup-freebsd-arm64@4.24.1 is failing from the latest release for rollup #5704

Closed

wiz mentioned this pull request Apr 28, 2025

Angular 17 -> 18 mempool/mempool#5814

Closed

lukastaegert mentioned this pull request May 25, 2025

Add NetBSD support #5962

Open

cyyynthia mentioned this pull request Aug 3, 2025

build: aggressively optimize wasm build, improve pipeline #6053

Merged

9 tasks

rpx99 mentioned this pull request Nov 5, 2025

feat: Add OpenBSD support for x64 and arm64 architectures #6163

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for FreeBSD (x64 and arm64)#5698

Add support for FreeBSD (x64 and arm64)#5698
lukastaegert merged 27 commits intorollup:masterfrom
tagattie:freebsd-support

tagattie commented Oct 21, 2024

Uh oh!

vercel bot commented Oct 21, 2024 •

edited

Loading

Uh oh!

lukastaegert left a comment •

edited

Loading

Uh oh!

codecov bot commented Oct 27, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 27, 2024

Uh oh!

lukastaegert commented Oct 27, 2024

Uh oh!

tagattie commented Oct 28, 2024

Uh oh!

lukastaegert commented Oct 28, 2024

Uh oh!

tagattie commented Oct 28, 2024

Uh oh!

lukastaegert commented Oct 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tagattie commented Oct 21, 2024

Description

Uh oh!

vercel bot commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukastaegert left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 27, 2024

Uh oh!

lukastaegert commented Oct 27, 2024

Uh oh!

tagattie commented Oct 28, 2024

Uh oh!

lukastaegert commented Oct 28, 2024

Uh oh!

tagattie commented Oct 28, 2024

Uh oh!

lukastaegert commented Oct 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Oct 21, 2024 •

edited

Loading

lukastaegert left a comment •

edited

Loading

codecov bot commented Oct 27, 2024 •

edited

Loading