Skip to content

fix: add space for DOCUMENT_CURRENT_SCRIPT template#5624

Merged
lukastaegert merged 2 commits intomasterfrom
fix/5623
Aug 26, 2024
Merged

fix: add space for DOCUMENT_CURRENT_SCRIPT template#5624
lukastaegert merged 2 commits intomasterfrom
fix/5623

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5623

Description

Add appropriate spaces to DOCUMENT_CURRENT_SCRIPT template as this commnet suggested.

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 3:30am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 24, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5623

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-bg35s1d4j-rollup-js.vercel.app/repl/?pr=5624

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 24, 2024

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.306 ± 0.051 9.247 9.337 1.00
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.331 ± 0.021 9.308 9.350 1.00 ± 0.01

Internal benchmark

  • BUILD: 8242ms, 748 MB
    • initialize: 0ms, 26 MB
    • generate module graph: 3134ms, 574 MB
      • generate ast: 1493ms, 567 MB
    • sort and bind modules: 449ms, 619 MB
    • mark included statements: 4655ms, 748 MB
      • treeshaking pass 1: 1576ms, 715 MB
      • treeshaking pass 2: 758ms, 742 MB
      • treeshaking pass 3: 298ms, 745 MB
      • treeshaking pass 4: 276ms, 752 MB
      • treeshaking pass 5: 322ms, 747 MB
      • treeshaking pass 6: 264ms, 752 MB
      • treeshaking pass 7: 249ms, 758 MB
      • treeshaking pass 8: 238ms, 756 MB
      • treeshaking pass 9: 218ms, 754 MB
      • treeshaking pass 10: 220ms, 752 MB
      • treeshaking pass 11: 217ms, 748 MB
  • GENERATE: 918ms, 1.02 GB
    • initialize render: 0ms, 914 MB
    • generate chunks: 92ms, 918 MB
      • optimize chunks: 0ms, 918 MB
    • render chunks: 800ms, 1 GB
    • transform chunks: 22ms, 1.02 GB
    • generate bundle: 0ms, 1.02 GB

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 21.85%. Comparing base (3eb8817) to head (8c71a1d).
Report is 2 commits behind head on master.

Current head 8c71a1d differs from pull request most recent head 8d70573

Please upload reports for the commit 8d70573 to get more accurate results.

Files Patch % Lines
src/utils/interopHelpers.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3eb8817) and HEAD (8c71a1d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3eb8817) HEAD (8c71a1d)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5624       +/-   ##
===========================================
- Coverage   99.05%   21.85%   -77.20%     
===========================================
  Files         242      231       -11     
  Lines        9324     8962      -362     
  Branches     2467     2377       -90     
===========================================
- Hits         9236     1959     -7277     
- Misses         58     6814     +6756     
- Partials       30      189      +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@lukastaegert lukastaegert added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 26, 2024
@lukastaegert lukastaegert merged commit eb07813 into master Aug 26, 2024
@lukastaegert lukastaegert deleted the fix/5623 branch August 26, 2024 15:19
@github-actions
Copy link
Copy Markdown

This PR has been released as part of rollup@4.21.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"import.meta.url" produced wrong code when output.compact is true and output.format is cjs or iife

2 participants