Call and await closeWatcher hooks on exit signals#5619
Merged
lukastaegert merged 1 commit intomasterfrom Aug 26, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-5615_close_watcher_signalNotice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report!Rough benchmark
Internal benchmark
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5619 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 242 242
Lines 9324 9325 +1
Branches 2467 2466 -1
=======================================
+ Hits 9236 9237 +1
+ Misses 58 57 -1
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. |
04f90bb to
e68a5d0
Compare
|
This PR has been released as part of rollup@4.21.1. You can test it via |
This was referenced Sep 17, 2024
This was referenced Sep 19, 2024
This was referenced Sep 21, 2024
This was referenced Sep 25, 2024
This was referenced Sep 30, 2024
This was referenced Oct 4, 2024
This was referenced Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Previously,
signal-exitwould not await our async handling of thecloseWatcherhook. This meant that when killing the watcher e.g. viaSIGINT, those hooks would not be called. This is fixed here by synchronously returningtruefrom the close handler.