Skip to content

preload the WASM file even though the version is undefined.#5618

Merged
lukastaegert merged 1 commit intomasterfrom
fix/5617
Aug 19, 2024
Merged

preload the WASM file even though the version is undefined.#5618
lukastaegert merged 1 commit intomasterfrom
fix/5617

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

@TrickyPi TrickyPi commented Aug 18, 2024 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2024 3:19pm

@TrickyPi TrickyPi closed this Aug 18, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 18, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5617

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-2rjyynqcf-rollup-js.vercel.app/repl/?pr=5618

@TrickyPi TrickyPi reopened this Aug 18, 2024
@TrickyPi TrickyPi changed the title tweak the position of fulfil Rollup loading preload the WASM file even though the version is undefined. Aug 18, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 18, 2024

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.168 ± 0.054 9.110 9.218 1.00
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.184 ± 0.016 9.169 9.201 1.00 ± 0.01

Internal benchmark

  • BUILD: 8208ms, 756 MB
    • initialize: 0ms, 26 MB
    • generate module graph: 3163ms, 575 MB
      • generate ast: 1523ms, 568 MB
    • sort and bind modules: 447ms, 616 MB
    • mark included statements: 4600ms, 756 MB
      • treeshaking pass 1: 1556ms, 720 MB
      • treeshaking pass 2: 755ms, 737 MB
      • treeshaking pass 3: 294ms, 742 MB
      • treeshaking pass 4: 272ms, 746 MB
      • treeshaking pass 5: 317ms, 754 MB
      • treeshaking pass 6: 265ms, 747 MB
      • treeshaking pass 7: 243ms, 752 MB
      • treeshaking pass 8: 237ms, 751 MB
      • treeshaking pass 9: 215ms, 751 MB
      • treeshaking pass 10: 219ms, 748 MB
      • treeshaking pass 11: 214ms, 756 MB
  • GENERATE: 885ms, 1.02 GB
    • initialize render: 0ms, 914 MB
    • generate chunks: 81ms, 922 MB
      • optimize chunks: 0ms, 916 MB
    • render chunks: 781ms, 1 GB
    • transform chunks: 16ms, 1.02 GB
    • generate bundle: 0ms, 1.02 GB

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@916bd62). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #5618   +/-   ##
=========================================
  Coverage          ?   99.05%           
=========================================
  Files             ?      242           
  Lines             ?     9324           
  Branches          ?     2467           
=========================================
  Hits              ?     9236           
  Misses            ?       58           
  Partials          ?       30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert added this pull request to the merge queue Aug 19, 2024
Merged via the queue into master with commit 262a388 Aug 19, 2024
@lukastaegert lukastaegert deleted the fix/5617 branch August 19, 2024 07:21
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 26, 2024

This PR has been released as part of rollup@4.21.1. You can test it via npm install rollup.

@pb-jeff-oneill pb-jeff-oneill mentioned this pull request Sep 13, 2024
Closed
@leonardoadame leonardoadame mentioned this pull request Sep 17, 2024
Open
This was referenced Sep 17, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 20, 2024
Open
This was referenced Sep 21, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 22, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Sep 23, 2024
Open
This was referenced Sep 23, 2024
Open
Open
Open
This was referenced Sep 25, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
This was referenced Oct 4, 2024
Open
Open
@YashGovekar YashGovekar mentioned this pull request Oct 4, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Oct 4, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TrickyPi @lukastaegert