Skip to content

feat: implementing decorator support#5562

Merged
lukastaegert merged 10 commits intomasterfrom
feat/decorator
Jul 20, 2024
Merged

feat: implementing decorator support#5562
lukastaegert merged 10 commits intomasterfrom
feat/decorator

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

@TrickyPi TrickyPi commented Jul 2, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5553

Description

This PR does not account for decorators with auto-accessor properties because this protocol has only reached Stage 1 at the moment.

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 5:01am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#feat/decorator

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-j2pu9248s-rollup-js.vercel.app/repl/?pr=5562

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2024

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.124 ± 0.080 9.043 9.202 1.01 ± 0.01
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.025 ± 0.040 8.986 9.066 1.00

Internal benchmark

  • BUILD: 8281ms, 751 MB
    • initialize: 0ms, 26 MB
    • generate module graph: 3176ms, 574 MB
      • generate ast: 1506ms, 567 MB
    • sort and bind modules: 445ms, 614 MB
    • mark included statements: 4665ms, 751 MB
      • treeshaking pass 1: 1580ms, 717 MB
      • treeshaking pass 2: 765ms, 735 MB
      • treeshaking pass 3: 306ms (+11ms, +3.8%), 747 MB
      • treeshaking pass 4: 279ms, 744 MB
      • treeshaking pass 5: 320ms, 750 MB
      • treeshaking pass 6: 264ms, 747 MB
      • treeshaking pass 7: 246ms, 750 MB
      • treeshaking pass 8: 240ms, 748 MB
      • treeshaking pass 9: 215ms, 753 MB
      • treeshaking pass 10: 218ms, 754 MB
      • treeshaking pass 11: 216ms, 751 MB
  • GENERATE: 895ms, 1.02 GB
    • initialize render: 0ms, 913 MB
    • generate chunks: 87ms, 919 MB
      • optimize chunks: 0ms, 916 MB
    • render chunks: 787ms, 1 GB
    • transform chunks: 18ms, 1.02 GB
    • generate bundle: 0ms, 1.02 GB

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (1d2c1e9) to head (d8ab5c3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5562   +/-   ##
=======================================
  Coverage   99.04%   99.05%           
=======================================
  Files         238      241    +3     
  Lines        9256     9273   +17     
  Branches     2441     2444    +3     
=======================================
+ Hits         9168     9185   +17     
  Misses         58       58           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TrickyPi
Copy link
Copy Markdown
Member Author

TrickyPi commented Jul 3, 2024

Hi Lukas, do you have any idea how to fix the failed tests? I added some log info for debugging and found that the AST of rollup.config.ts is incorrect. See https://github.com/rollup/rollup/actions/runs/9777093939/job/26991182657
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JS Decorator Stage 3 support

4 participants