Watch rust files and rebuild during dev#5543
Merged
lukastaegert merged 2 commits intomasterfrom Jun 23, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
64bff36 to
c4e62aa
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#watch-rust-devNotice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report!Rough benchmark
Internal benchmark
|
c4e62aa to
37c1088
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5543 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 238 238
Lines 9544 9544
Branches 2437 2437
=======================================
Hits 9456 9456
Misses 58 58
Partials 30 30 ☔ View full report in Codecov by Sentry. |
37c1088 to
5a4039f
Compare
|
This PR has been released as part of rollup@4.18.1. You can test it via |
This was referenced Jul 30, 2024
This was referenced Aug 2, 2024
This was referenced Aug 9, 2024
This was referenced Sep 17, 2024
This was referenced Sep 19, 2024
This was referenced Sep 25, 2024
This was referenced Oct 2, 2024
This was referenced Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This greatly improves the usefulness of
npm run devby rebuilding the browser wasm build on Rust changes, which will also update and reload the REPL if it is open.I went for nodemon because