fix: parameter variable infinite recursion error#5500
Merged
lukastaegert merged 2 commits intorollup:masterfrom Apr 29, 2024
Merged
fix: parameter variable infinite recursion error#5500lukastaegert merged 2 commits intorollup:masterfrom
lukastaegert merged 2 commits intorollup:masterfrom
Conversation
Ensure before hasEffects of function body (triggered by function call), the arguments are first provided
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5500 +/- ##
==========================================
- Coverage 98.81% 98.81% -0.01%
==========================================
Files 238 238
Lines 9540 9538 -2
Branches 2436 2436
==========================================
- Hits 9427 9425 -2
Misses 48 48
Partials 65 65 ☔ View full report in Codecov by Sentry. |
lukastaegert
approved these changes
Apr 29, 2024
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Amazing, thanks for the quick fix. Yes, NewExpression and TaggedTemplateExpression should be the only other places where we call a variable. There is some additional call deoptimization logic in knownGlobals.ts, but I think that should be non-critical.
|
This PR has been released as part of rollup@4.17.1. You can test it via |
9 tasks
This was referenced May 21, 2024
This was referenced May 23, 2024
This was referenced Jun 1, 2024
This was referenced Aug 25, 2024
This was referenced Sep 2, 2024
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
The function parameter will only get a known value when it is the callee of a function call. It is also where the
hasEffectsof function body gets called (and the only place?), we need to make sure the known value is set first, thenhasEffectsof function body gets called forNewExpressionandTaggedTemplateExpressiontoo. In that case, we can get exactly a "call tree" instead of a "call graph", so the known value of a parameter is guaranteed to come from somewhere outside the function and is guaranteed to from a "analyzed" code/function.