Skip to content

Update documentation#5382

Merged
lukastaegert merged 2 commits intomasterfrom
docs/xiaopi
Feb 8, 2024
Merged

Update documentation#5382
lukastaegert merged 2 commits intomasterfrom
docs/xiaopi

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

@TrickyPi TrickyPi commented Feb 7, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5376
resolves #5375

Description

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Feb 7, 2024 1:29pm

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#docs/xiaopi

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-dev23tngu-rollup-js.vercel.app/repl/?pr=5382

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14425f9) 98.81% compared to head (ab30ae9) 98.81%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5382   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         232      232           
  Lines        8997     8997           
  Branches     2347     2347           
=======================================
  Hits         8890     8890           
  Misses         46       46           
  Partials       61       61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lukastaegert
lukastaegert approved these changes Feb 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking care!

@lukastaegert lukastaegert added this pull request to the merge queue Feb 8, 2024
Merged via the queue into master with commit 63a91a6 Feb 8, 2024
@lukastaegert lukastaegert deleted the docs/xiaopi branch February 8, 2024 11:41
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 10, 2024

This PR has been released as part of rollup@4.10.0. You can test it via npm install rollup.

This was referenced Feb 10, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace glob.sync by globSync in code example importing rollup from esm.sh doesn't work

2 participants

@TrickyPi @lukastaegert