Skip to content

Roll back vitepress as 1.0.0-rc.40 breaks the development build#5372

Merged
lukastaegert merged 1 commit intomasterfrom
rollback-vitepress
Feb 2, 2024
Merged

Roll back vitepress as 1.0.0-rc.40 breaks the development build#5372
lukastaegert merged 1 commit intomasterfrom
rollback-vitepress

Conversation

@lukastaegert
Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

npm run dev was breaking with JavaScript errors that pointed to issues with the vite server.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Feb 2, 2024 0:07am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 2, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#rollback-vitepress

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-5swt7fw7q-rollup-js.vercel.app/repl/?pr=5372

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19fe138) 98.81% compared to head (6511de2) 98.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5372   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         232      232           
  Lines        8997     8997           
  Branches     2347     2347           
=======================================
  Hits         8890     8890           
  Misses         46       46           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit 14425f9 into master Feb 2, 2024
@lukastaegert lukastaegert deleted the rollback-vitepress branch February 2, 2024 12:24
@github-actions
Copy link
Copy Markdown

This PR has been released as part of rollup@4.10.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant