Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#check-d-tsNotice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5340 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 232 232
Lines 8993 8993
Branches 2345 2345
=======================================
Hits 8886 8886
Misses 46 46
Partials 61 61 ☔ View full report in Codecov by Sentry. |
Changing module-resolution to "Bundler" indeed solve all issues
d6003ff to
b63d9cd
Compare
|
This PR has been released as part of rollup@4.9.6. You can test it via |
Changing module-resolution to "Bundler" indeed solve all issues
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Apparently, we no longer need "skipLibCheck: true" if we change moduleResolution to "Bundler" in relevant places. This allows us to type check all d.ts files, which might be important for some forthcoming type changes.