build: static link msvc runtime on Windows x64 platform#5335
Merged
lukastaegert merged 1 commit intorollup:masterfrom Jan 11, 2024
Merged
build: static link msvc runtime on Windows x64 platform#5335lukastaegert merged 1 commit intorollup:masterfrom
lukastaegert merged 1 commit intorollup:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
11 tasks
lukastaegert
approved these changes
Jan 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5335 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 232 232
Lines 8983 8983
Branches 2342 2342
=======================================
Hits 8877 8877
Misses 46 46
Partials 60 60 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.9.5. You can test it via |
User@Desktop UCRT64 ~/
$ npx rollup
Need to install the following packages:
rollup@4.9.5
Ok to proceed? (y) y
thread '<unnamed>' panicked at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\napi-sys-2.3.0\src\functions.rs:7:3:
Must load N-API bindings
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace |
|
ahh this might depend on wasm-pack |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: vercel/next.js#55505
Reported issues: