Do not handle declarations in modules without side effects as TDZ#5322
Do not handle declarations in modules without side effects as TDZ#5322lukastaegert merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-5317-module-side-effectsNotice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5322 +/- ##
==========================================
- Coverage 98.82% 98.82% -0.01%
==========================================
Files 232 232
Lines 8974 8973 -1
Branches 2338 2338
==========================================
- Hits 8869 8868 -1
Misses 46 46
Partials 59 59 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.9.2. You can test it via |
… TDZ (rollup#5322)" This reverts commit ba1c2db.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This ignores the TDZ detection logic when the variable is inside a module with moduleSideEffects=false as the logic would otgherwise detect false positives.