Skip to content

Remove rollup-plugin-thatworks from devDeps#5312

Merged
lukastaegert merged 1 commit intomasterfrom
chore/remove-dev-deps
Dec 26, 2023
Merged

Remove rollup-plugin-thatworks from devDeps#5312
lukastaegert merged 1 commit intomasterfrom
chore/remove-dev-deps

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

@TrickyPi TrickyPi commented Dec 25, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Because Rollup V4 preserves the shebang, I believe we no longer need this plugin.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Dec 25, 2023 3:24pm

@TrickyPi TrickyPi changed the title chore: remove rollup-plugin-thatworks from devDeps Remove rollup-plugin-thatworks from devDeps Dec 25, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 25, 2023 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#chore/remove-dev-deps

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-jpskqpgta-rollup-js.vercel.app/repl/?pr=5312

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7403a6a) 98.82% compared to head (1a15d6a) 98.82%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5312   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         232      232           
  Lines        8974     8974           
  Branches     2338     2338           
=======================================
  Hits         8869     8869           
  Misses         46       46           
  Partials       59       59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert added this pull request to the merge queue Dec 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 26, 2023
@lukastaegert lukastaegert added this pull request to the merge queue Dec 26, 2023
Merged via the queue into master with commit 15916fb Dec 26, 2023
@lukastaegert lukastaegert deleted the chore/remove-dev-deps branch December 26, 2023 08:31
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 30, 2023

This PR has been released as part of rollup@4.9.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TrickyPi @lukastaegert