Skip to content

Add JSDoc types to internal scripts#5305

Merged
lukastaegert merged 3 commits intomasterfrom
script-types
Dec 23, 2023
Merged

Add JSDoc types to internal scripts#5305
lukastaegert merged 3 commits intomasterfrom
script-types

Conversation

@lukastaegert
Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This adds (strict) JSDocs types to all scripts in the scripts folder. This will hopefully help as I want to add some scripts to generate AST transformation code to ensure that encoders and decoders are always synced.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 7:30am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 18, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#script-types

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-llz7xngiw-rollup-js.vercel.app/repl/?pr=5305

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d56ac63) 98.82% compared to head (ae78890) 98.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5305   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         232      232           
  Lines        8974     8974           
  Branches     2338     2338           
=======================================
  Hits         8869     8869           
  Misses         46       46           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

This PR has been released as part of rollup@4.9.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant