Skip to content

Do not assume setTimeout return type#5296

Merged
lukastaegert merged 1 commit intorollup:masterfrom
kapouer:patch-1
Dec 12, 2023
Merged

Do not assume setTimeout return type#5296
lukastaegert merged 1 commit intorollup:masterfrom
kapouer:patch-1

Conversation

@kapouer
Copy link
Copy Markdown
Contributor

@kapouer kapouer commented Dec 12, 2023

It typically changed between Node 18.13 and 18.19

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

It typically changed between Node 18.13 and 18.19
@vercel
Copy link
Copy Markdown

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 11:09am

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62b648e) 98.82% compared to head (8a1c4a2) 98.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5296   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         232      232           
  Lines        8962     8962           
  Branches     2336     2336           
=======================================
  Hits         8857     8857           
  Misses         46       46           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert added this pull request to the merge queue Dec 12, 2023
Merged via the queue into rollup:master with commit 7f9d85c Dec 12, 2023
@github-actions
Copy link
Copy Markdown

This PR has been released as part of rollup@4.9.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants