Add friendly error for missing MSVC redistributable#5284
Merged
lukastaegert merged 1 commit intorollup:masterfrom Dec 7, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cc2caa4 to
e01b7dc
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5284 +/- ##
==========================================
- Coverage 98.86% 98.82% -0.04%
==========================================
Files 232 232
Lines 8953 8957 +4
Branches 2336 2336
==========================================
+ Hits 8851 8852 +1
- Misses 43 46 +3
Partials 59 59 ☔ View full report in Codecov by Sentry. |
lukastaegert
approved these changes
Dec 7, 2023
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks, this looks like a good idea!
|
This PR has been released as part of rollup@4.7.0. You can test it via |
|
Related on Stack Overflow: Error in React vite project due to rollup dependency (module not found) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
(searching with
ERR_DLOPEN_FAILED vite OR rollup site:stackoverflow.comgives 7 hits too)Description
I saw many people facing
ERR_DLOPEN_FAILEDerror caused by missing DLL on Windows.This PR adds a message about that. I didn't find a way to obtain which DLL is missing, so I made the message a bit general.