Skip to content

Add logs and experimentalLogSideEffects to REPL#5281

Merged
lukastaegert merged 1 commit intomasterfrom
logs-in-repl
Dec 3, 2023
Merged

Add logs and experimentalLogSideEffects to REPL#5281
lukastaegert merged 1 commit intomasterfrom
logs-in-repl

Conversation

@lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This will add the experimentalLogsSideEffects option to the REPL and allow the REPL to display logs.

@vercel
Copy link

vercel bot commented Dec 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2023 0:25am

@github-actions
Copy link

github-actions bot commented Dec 2, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#logs-in-repl

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-h1ck0ou9x-rollup-js.vercel.app/repl/?pr=5281

@codecov
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fda165d) 98.86% compared to head (2c81575) 98.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5281   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files         232      232           
  Lines        8953     8953           
  Branches     2336     2336           
=======================================
  Hits         8851     8851           
  Misses         43       43           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

This PR has been released as part of rollup@4.7.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant