Allow to redeclare parameters multiple times in nested scopes#5276
Allow to redeclare parameters multiple times in nested scopes#5276lukastaegert merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-5274_redeclare_parameter_varNotice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5276 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 232 232
Lines 8952 8953 +1
Branches 2335 2336 +1
=======================================
+ Hits 8850 8851 +1
Misses 43 43
Partials 59 59 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.6.1. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
When a parameter is redeclared as a
varseveral times in the same nested scope (or in several child scopes of the same nested scope), then this caused a conflict due to some aspects of the var-conflict detection logic. This is fixed here by adding an exception when a var redeclares a parameter.