doc fix import assertions to attributes in API plugin development page#5251
Merged
lukastaegert merged 1 commit intorollup:masterfrom Nov 17, 2023
lhapaipai:doc/update-plugin-development
Merged
doc fix import assertions to attributes in API plugin development page#5251lukastaegert merged 1 commit intorollup:masterfrom lhapaipai:doc/update-plugin-development
lukastaegert merged 1 commit intorollup:masterfrom
lhapaipai:doc/update-plugin-development
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5251 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 232 232
Lines 8936 8936
Branches 2333 2333
=======================================
Hits 8837 8837
Misses 40 40
Partials 59 59 ☔ View full report in Codecov by Sentry. |
lukastaegert
approved these changes
Nov 17, 2023
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Thank you so much. I was sure that I had changed from assertions to attributes everywhere, but apparently, I missed this entire file...
|
This PR has been released as part of rollup@4.5.0. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Hello this PR allows you to update the documentation page: API plugin development.
https://rollupjs.org/plugin-development/#generatebundle
Indeed, the documentation still uses the term
assertionswhereas we must now useattributes.there is also a small correction in an example where it was necessary to use the
resolveIdhook instead ofload.