perf: shrink wasm size by avoid importing browserslist#5204
Merged
lukastaegert merged 1 commit intorollup:masterfrom Oct 15, 2023
Merged
perf: shrink wasm size by avoid importing browserslist#5204lukastaegert merged 1 commit intorollup:masterfrom
lukastaegert merged 1 commit intorollup:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #5204 +/- ##
=======================================
Coverage 98.82% 98.82%
=======================================
Files 231 231
Lines 8849 8849
Branches 2314 2314
=======================================
Hits 8745 8745
Misses 43 43
Partials 61 61 |
lukastaegert
approved these changes
Oct 15, 2023
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Amazing find, thanks a lot!
|
This PR has been released as part of rollup@4.1.4. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This PR reduces the wasm size by ~70% by avoid importing browserslist.
swc crate imports browserslist-rs indirectly and because browserslist-rs has
#[wasm_bindgen]that function was exposed and the dependencies of that function was included in the wasm binary.wasm: 5.20MB -> 1.54MB
node (windows): 3.32MB -> 3.31MB