Allow shouldTransformCachedModule to return null#4932
Merged
lukastaegert merged 3 commits intorollup:masterfrom Apr 11, 2023
bluwy:shouldTransformCachedModule-null
Merged
Allow shouldTransformCachedModule to return null#4932lukastaegert merged 3 commits intorollup:masterfrom bluwy:shouldTransformCachedModule-null
lukastaegert merged 3 commits intorollup:masterfrom
bluwy:shouldTransformCachedModule-null
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #4932 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 221 221
Lines 8052 8052
Branches 2216 2216
=======================================
Hits 7973 7973
Misses 26 26
Partials 53 53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
This PR has been released as part of rollup@3.20.3-0. Note that this is a pre-release, so to test it, you need to install Rollup via |
Collaborator
|
This PR has been released as part of rollup@3.20.3. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Allow
shouldTransformCachedModuleto return null. The hook uses thehookFirstapproach, which only delegates other plugins if the return value is null.rollup/src/utils/PluginDriver.ts
Lines 141 to 154 in 0bcf0a6
Since the types only restricts returning a
boolean, it makes it that the first plugin that implements this will take precedence over everything. Allowing to return null should fix this.Perhaps there could be discussion if this was intentional.