Skip to content

Fix syntax error in manualChunks example#6190

Merged
lukastaegert merged 1 commit intorollup:masterfrom
jonnyeom:patch-1
Nov 29, 2025
Merged

Fix syntax error in manualChunks example#6190
lukastaegert merged 1 commit intorollup:masterfrom
jonnyeom:patch-1

Conversation

@jonnyeom
Copy link
Copy Markdown
Contributor

@jonnyeom jonnyeom commented Nov 25, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 25, 2025

@jonnyeom is attempting to deploy a commit to the rollup-js Team on Vercel.

A member of the Team first needs to authorize it.

lukastaegert
lukastaegert approved these changes Nov 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rollup Ready Ready Preview Comment Nov 29, 2025 6:44pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (0e38255) to head (b9c9c24).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6190   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         271      271           
  Lines       10646    10646           
  Branches     2850     2850           
=======================================
  Hits        10512    10512           
  Misses         91       91           
  Partials       43       43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukastaegert lukastaegert added this pull request to the merge queue Nov 29, 2025
Merged via the queue into rollup:master with commit c5f3e1d Nov 29, 2025
44 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 15, 2025

This PR has been released as part of rollup@4.53.4. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonnyeom @lukastaegert