Add support for openharmony-arm64 platform#6081
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5bc6fda to
cd50c76
Compare
lukastaegert
left a comment
There was a problem hiding this comment.
Nice! Before merging this, I want to merge #6078 though, which changes the build pipeline, probably on Monday. After that, you may want to check if you need to update this PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6081 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 271 271
Lines 10620 10620
Branches 2838 2838
=======================================
Hits 10492 10492
Misses 88 88
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Got it, I'll wait and re-check the PR. |
cd50c76 to
2a671c4
Compare
2a671c4 to
b211865
Compare
|
I have updated this PR after #6078 was merged. You can continue to review this PR now. @lukastaegert |
|
This PR has been released as part of rollup@4.50.0. You can test it via |
|
It works. @lukastaegert |
|
HarmonyOS is a special commercial distribution of OpenHarmony. Compared with the community edition of OpenHarmony, this distribution imposes many additional security restrictions. For example, when loading a dynamic library on HarmonyOS, the library must carry a valid code signature. Your issue is most likely caused by rollup.openharmony-arm64.node lacking such a signature, so the system refuses to load it. At the moment, however, I have no plan to add a dedicated signature for HarmonyOS. Vendors have not yet provided a mature toolchain or a complete signing workflow; I prefer to wait until they improve both the toolchain and the security mechanisms before tackling signature-related work. In the meantime, you can try using the npm package ohos-signpost to work around the problem. If you have further questions, feel free to email me directly. |
ok,i will try the solution you provided first, thank you |
This PR contains:
Are tests included?
Breaking Changes?
Description
Thanks to the support for OpenHarmony in Node.js and napi-rs, we can easily make Rollup support this platform.
I referred to Rolldown(rolldown/rolldown#5258) to do this, and I have already verified it by setting up a private repository using Verdacio locally.