Skip to content

Conversation

@TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Jan 4, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5762

Description

@vercel
Copy link

vercel bot commented Jan 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 8:30am

@github-actions
Copy link

github-actions bot commented Jan 4, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5762

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-pntcg10l6-rollup-js.vercel.app/repl/?pr=5781

@github-actions
Copy link

github-actions bot commented Jan 4, 2025

Performance report

  • BUILD: 7385ms, 735 MB
    • initialize: 0ms, 27.2 MB
    • generate module graph: 2774ms, 549 MB
      • generate ast: 1248ms, 544 MB
    • sort and bind modules: 395ms, 594 MB
    • mark included statements: 4218ms, 735 MB
      • treeshaking pass 1: 1377ms, 698 MB
      • treeshaking pass 2: 668ms, 722 MB
      • treeshaking pass 3: 276ms, 727 MB
      • treeshaking pass 4: 260ms, 724 MB
      • treeshaking pass 5: 298ms, 733 MB
      • treeshaking pass 6: 249ms, 728 MB
      • treeshaking pass 7: 230ms, 734 MB
      • treeshaking pass 8: 226ms, 733 MB
      • treeshaking pass 9: 207ms, 730 MB
      • treeshaking pass 10: 208ms, 730 MB
      • treeshaking pass 11: 204ms, 735 MB
  • GENERATE: 720ms (+15ms, +2.2%), 968 MB
    • initialize render: 0ms, 868 MB
    • generate chunks: 73ms, 879 MB
      • optimize chunks: 0ms, 877 MB
    • render chunks: 627ms, 947 MB
    • transform chunks: 18ms, 968 MB
    • generate bundle: 0ms, 968 MB

@codecov
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (15f72a8) to head (a5e863a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5781   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         259      259           
  Lines        8090     8090           
  Branches     1363     1363           
=======================================
  Hits         8010     8010           
  Misses         53       53           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was surprisingly simple, thanks a lot!

@lukastaegert lukastaegert added this pull request to the merge queue Jan 5, 2025
Merged via the queue into master with commit 0c70b6b Jan 5, 2025
42 checks passed
@lukastaegert lukastaegert deleted the fix/5762 branch January 5, 2025 06:47
@github-actions
Copy link

github-actions bot commented Jan 5, 2025

This PR has been released as part of rollup@4.29.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent output of dynamic import between cjs and es format

3 participants