-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: keep import attributes for cjs format #5781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix/5762Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5781 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 259 259
Lines 8090 8090
Branches 1363 1363
=======================================
Hits 8010 8010
Misses 53 53
Partials 27 27 ☔ View full report in Codecov by Sentry. |
lukastaegert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was surprisingly simple, thanks a lot!
|
This PR has been released as part of rollup@4.29.2. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #5762
Description