Skip to content

Resolve all rollup imports to node_modules to avoid type conflict#5386

Merged
lukastaegert merged 1 commit intomasterfrom
fix/build-xiaopi
Feb 10, 2024
Merged

Resolve all rollup imports to node_modules to avoid type conflict#5386
lukastaegert merged 1 commit intomasterfrom
fix/build-xiaopi

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 5:21am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 10, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/build-xiaopi

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-edg8deyb3-rollup-js.vercel.app/repl/?pr=5386

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fecd35) 98.81% compared to head (e466d56) 98.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5386   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         232      232           
  Lines        9009     9009           
  Branches     2351     2351           
=======================================
  Hits         8902     8902           
  Misses         46       46           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TrickyPi
Copy link
Copy Markdown
Member Author

@lukastaegert I hope this PR can fix the current build problem.

@lukastaegert lukastaegert force-pushed the master branch 2 times, most recently from 5101ee6 to 8fecd35 Compare February 10, 2024 05:08
@lukastaegert
Copy link
Copy Markdown
Member

I think in the end, the problem was just the removal of skipLibCheck, but the other changes are welcome as well

@lukastaegert lukastaegert added this pull request to the merge queue Feb 10, 2024
Merged via the queue into master with commit b4164c5 Feb 10, 2024
@lukastaegert lukastaegert deleted the fix/build-xiaopi branch February 10, 2024 05:40
@github-actions
Copy link
Copy Markdown

This PR has been released as part of rollup@4.10.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants